[PATCH] D33844: [clang-tidy] terminating continue check

This revision was automatically updated to reflect the committed changes. Closed by commit rL332223: [clang-tidy] Add terminating continue check (authored by xazax, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.org/D33844?vs=142793

[PATCH] D33844: [clang-tidy] terminating continue check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D33844#1095862, @koldaniel wrote: > In https://reviews.llvm.org/D33844#1086565, @alexfh wrote: > > > > > > Which comments do you think are still relevant? Weird. W

[PATCH] D33844: [clang-tidy] terminating continue check

koldaniel added a comment. In https://reviews.llvm.org/D33844#1086565, @alexfh wrote: > Which comments do you think are still relevant? https://reviews.llvm.org/D33844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D33844: [clang-tidy] terminating continue check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. There are still outstanding comments. https://reviews.llvm.org/D33844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D33844: [clang-tidy] terminating continue check

koldaniel updated this revision to Diff 142793. https://reviews.llvm.org/D33844 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/TerminatingContinueCheck.cpp clang-tidy/bugprone/TerminatingContinueCheck.h docs/ReleaseNotes.rst do

[PATCH] D33844: [clang-tidy] terminating continue check

alexfh added a comment. Please move the check to bugprone- module. clang-tidy/rename_check.py script should do most of the job (you'll have to remove the unnecessary "renamed check ..." entry in the release notes). Comment at: clang-tidy/misc/TerminatingContinueCheck.cpp:27 +

[PATCH] D33844: [clang-tidy] terminating continue check

JonasToth added inline comments. Comment at: test/clang-tidy/misc-terminating-continue.cpp:7 +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: terminating 'continue' [misc-terminating-continue] + } while(false); + Quuxplusone wrote: > I initially expected to see

[PATCH] D33844: [clang-tidy] terminating continue check

koldaniel updated this revision to Diff 139953. https://reviews.llvm.org/D33844 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/TerminatingContinueCheck.cpp clang-tidy/misc/TerminatingContinueCheck.h docs/clang-tidy/checks/list.rst docs/clang-t

[PATCH] D33844: [clang-tidy] terminating continue check

Quuxplusone added inline comments. Comment at: clang-tidy/misc/TerminatingContinueCheck.cpp:42 + + auto Diag = diag(ContStmt->getLocStart(), "terminating 'continue'"); + Diag << FixItHint::CreateReplacement(ContStmt->getSourceRange(), "break"); It was not clear

[PATCH] D33844: [clang-tidy] terminating continue check

JonasToth added a comment. I think this check could land in the `bugprone` module. Given this situation won't appear a lot in codebases, did you check other codebases than LLVM? Comment at: clang-tidy/misc/TerminatingContinueCheck.h:19 + +/// Checks if a 'continue' statement