rsmith accepted this revision.
rsmith added a comment.
Thanks, do you need someone to commit this for you?
https://reviews.llvm.org/D33833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
kuang_he updated this revision to Diff 104018.
https://reviews.llvm.org/D33833
Files:
lib/AST/DeclCXX.cpp
test/SemaTemplate/destructor-template.cpp
Index: test/SemaTemplate/destructor-template.cpp
===
--- test/SemaTemplate/dest
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: test/SemaCXX/PR33189.cpp:1-7
+// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s
+
+class U
+{
+ template
+ ~U() { } // expected-error{{destructor cann
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D33833#789436, @kuang_he wrote:
> Can we get this patch reviewed by any chance?
@kuang_he; it is customary to "ping". In this case, "Ping 2".
Comment at: lib/AST/DeclCXX.cpp:1421
- CXXDestructorDecl *Dtor
kuang_he added a comment.
Can we get this patch reviewed by any chance?
https://reviews.llvm.org/D33833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kuang_he added a comment.
Can we have this patch reviewed?
https://reviews.llvm.org/D33833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kuang_he updated this revision to Diff 101601.
kuang_he added a comment.
Patch updated addressing comment.
https://reviews.llvm.org/D33833
Files:
lib/AST/DeclCXX.cpp
test/SemaCXX/PR33189.cpp
Index: test/SemaCXX/PR33189.cpp
==
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1420
DeclContext::lookup_result R = lookup(Name);
- if (R.empty())
+ if (R.empty() || !isa(R.front()))
return nullptr;
As it is,
```
return R.empty() ? nullptr : dyn_cast(R.fr
