This revision was automatically updated to reflect the committed changes.
Closed by commit rL309256: [PowerPC] Pass CPU to assembler with
-no-integrated-as (authored by nemanjai).
Changed prior to commit:
https://reviews.llvm.org/D33820?vs=101508&id=108434#toc
Repository:
rL LLVM
https://re
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sorry, when I say "One inline comment otherwise LGTM" feel free to commit after
fixing :)
Since you have, then LGTM.
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D33820
nemanjai added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D33820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nemanjai updated this revision to Diff 101508.
nemanjai added a comment.
Remove the temporary string variable for the CPU.
Repository:
rL LLVM
https://reviews.llvm.org/D33820
Files:
lib/Driver/ToolChains/Arch/PPC.cpp
lib/Driver/ToolChains/Arch/PPC.h
lib/Driver/ToolChains/Gnu.cpp
test
echristo added a comment.
One inline comment otherwise LGTM
Comment at: lib/Driver/ToolChains/Gnu.cpp:681
CmdArgs.push_back("-mppc");
-CmdArgs.push_back("-many");
+std::string CPU = getCPUName(Args, getToolChain().getTriple());
+CmdArgs.push_back(ppc::getPPCAsm
nemanjai updated this revision to Diff 101169.
nemanjai added a comment.
Initially, forgot to add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D33820
Files:
lib/Driver/ToolChains/Arch/PPC.cpp
lib/Driver/ToolChains/Arch/PPC.h
lib/Driver/ToolChains/Gnu.cpp
test/Driver/linu
nemanjai created this revision.
This just adds the CPU to a list of commands passed to GAS when not using the
integrated assembler.
Repository:
rL LLVM
https://reviews.llvm.org/D33820
Files:
lib/Driver/ToolChains/Arch/PPC.cpp
lib/Driver/ToolChains/Arch/PPC.h
lib/Driver/ToolChains/Gnu.
