GorNishanov closed this revision.
GorNishanov added a comment.
Tested checked in. Thank you for looking into this, Reid!
r304380 = 1c0d15a4bf10876bb233e921907e114d52bee82e
https://reviews.llvm.org/D33733
___
cfe-commits mailing list
cfe-commits@lis
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
rnk wrote:
> It looks like this is the expression in que
rnk added inline comments.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
It looks like this is the expression in question. This expression should have
aggregate evaluation kind, not scalar. We don't need t
GorNishanov created this revision.
This is a follow up for the https://reviews.llvm.org/rL297084 which made sure
that dominance is preserved during expression cleanup emission.
We ran into a case where dominance fixup code was inserting the store in the
middle of allocas.
%x = alloca i32, ali
