Re: [PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-06-07 Thread Eric Fiselier via cfe-commits
Yes, the thing that it's supposed to be testing is -Wuninitialized and other analysis warnings. I'll re-name the test and add more test cases to this effect shortly. Thanks for the input. On Mon, Jun 5, 2017 at 10:33 AM, David Blaikie wrote: > > > On Mon, May 29, 2017 at 3:28 PM Eric Fiselier v

Re: [PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-06-05 Thread David Blaikie via cfe-commits
On Mon, May 29, 2017 at 3:28 PM Eric Fiselier via Phabricator via cfe-commits wrote: > EricWF created this revision. > > @rsmith Is there a better place to put this test? > > > https://reviews.llvm.org/D33660 > > Files: > lib/Sema/SemaCoroutine.cpp > test/SemaCXX/coreturn.cpp > test/SemaCXX

[PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-05-30 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LBTM (Looks brilliant to me) https://reviews.llvm.org/D33660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-05-29 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. @rsmith Is there a better place to put this test? https://reviews.llvm.org/D33660 Files: lib/Sema/SemaCoroutine.cpp test/SemaCXX/coreturn.cpp test/SemaCXX/coroutine-uninitialized-warning-crash.cpp Index: test/SemaCXX/coroutine-uninitialized-warning-crash.cp