This revision was automatically updated to reflect the committed changes.
Closed by commit rL304523: Mangle __unaligned in Itanium ABI (authored by
rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D33398?vs=100974&id=101171#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33398
rsmith accepted this revision.
rsmith added a comment.
Looks great, thanks!
Comment at: lib/AST/ItaniumMangle.cpp:2210
+ if (Quals.hasUnaligned())
+ mangleVendorQualifier("__unaligned");
+
rogfer01 wrote:
> rsmith wrote:
> > Too much indentation here. Als
rogfer01 added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:2210
+ if (Quals.hasUnaligned())
+ mangleVendorQualifier("__unaligned");
+
rsmith wrote:
> Too much indentation here. Also, the ABI requires the "unordered" vendor
> qualifiers to be emi
rogfer01 updated this revision to Diff 100974.
rogfer01 added a comment.
Changelog:
- Fix formatting.
- Emit `__unaligned` in the right order (as defined by the Itanium ABI) when
there are Objective-C++ ARC vendor qualifiers.
- New test for `__unaligned` and ARC's `__weak`, `__strong` and `__aut
rsmith added a comment.
In https://reviews.llvm.org/D33398#769152, @rnk wrote:
> Isn't there a space in the mangling for vendor extensions? Can we use that
> here?
We are using that here: that's what `mangleVendorQualifier` does.
Comment at: lib/AST/ItaniumMangle.cpp:2210
+
rnk added a comment.
This was filed as https://bugs.llvm.org/show_bug.cgi?id=33178
Isn't there a space in the mangling for vendor extensions? Can we use that here?
https://reviews.llvm.org/D33398
___
cfe-commits mailing list
cfe-commits@lists.llvm.
rogfer01 updated this revision to Diff 100868.
rogfer01 added a comment.
Fix formatting of tests.
Thanks for the review @aaron.ballman !
https://reviews.llvm.org/D33398
Files:
lib/AST/ItaniumMangle.cpp
test/CodeGenCXX/pr33080.cpp
test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp
tes
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Can you run clang-format over both the test files? Aside from that, looks good
to me, but you should wait for @rsmith or @majnemer to sign off before
committing.
https://review
rogfer01 updated this revision to Diff 100670.
rogfer01 added a comment.
Thanks @aaron.ballman for the review.
I have extended the test with your suggestions.
https://reviews.llvm.org/D33398
Files:
lib/AST/ItaniumMangle.cpp
test/CodeGenCXX/pr33080.cpp
test/CodeGenCXX/unaligned-duplicated
aaron.ballman added inline comments.
Comment at: test/CodeGenCXX/pr33080.cpp:19
+void hb(__unaligned struct A*, __unaligned const struct A*) {}
+// CHECK: define void @_Z2hbPU11__unaligned1APU11__unalignedKS_(
Can we also get a test like `struct A * __unaligned *
rogfer01 updated this revision to Diff 99876.
rogfer01 retitled this revision from "Remove __unaligned preventively when
mangling types in Itanium ABI" to "Mangle __unaligned in Itanium ABI".
rogfer01 edited the summary of this revision.
rogfer01 added a reviewer: majnemer.
rogfer01 added a commen
11 matches
Mail list logo
