marcel abandoned this revision.
marcel added a comment.
Closed. Patch https://reviews.llvm.org/D33368 addresses PR32890 more
comprehensively.
https://reviews.llvm.org/D33393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
erik.pilkington added a comment.
> but having a constant like this ("7") sounds wrong. Why not 6, or 8, or 42?
7 is correct here because we inserting into a specific point into a string that
was inserted into db.names just above this (but out of context from the diff).
The only problem is that
kcc added a comment.
I don't know this code and can't properly comment, but having a constant like
this ("7") sounds wrong.
Why not 6, or 8, or 42?
https://reviews.llvm.org/D33393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
erik.pilkington added a comment.
> You could append my test case as a quick-check.
Sure, I added the test case here to my patch and it works.
> So, I'll go ahead and abandon this revision?
Guess so, sorry for the confusion here.
https://reviews.llvm.org/D33393
_
marcel added a comment.
In https://reviews.llvm.org/D33393#761679, @erik.pilkington wrote:
> Do you agree that this is the right approach here?
Sure. As long as it fixes PR32890.
You could append my test case as a quick-check.
So, I'll go ahead and abandon this revision?
https://reviews.llvm
erik.pilkington added a comment.
Could you please add more context lines in any future patches? Makes it easier
to review!
I think we fixed the same problem at the same time, I have
https://reviews.llvm.org/D33368 that also fixes this! The reason that inserting
into db.names.back() sometimes r
marcel updated this revision to Diff 99850.
marcel added a comment.
Fixing off-by-one. Passes `make check-cxxabi` for LLVM in trunk on my machine
(x86-64, Ubuntu 16.04).
https://reviews.llvm.org/D33393
Files:
CREDITS.TXT
src/cxa_demangle.cpp
test/test_demangle.pass.cpp
Index: test/test
marcel added inline comments.
Comment at: src/cxa_demangle.cpp:3078-3079
++t1;
-db.names.back().first.insert(db.names.back().first.begin()+7,
t0, t1);
+if (db.names.back().first.length() > 7)
+ db.names.back()
dexonsmith added a reviewer: erik.pilkington.
dexonsmith added inline comments.
Comment at: src/cxa_demangle.cpp:3078-3079
++t1;
-db.names.back().first.insert(db.names.back().first.begin()+7,
t0, t1);
+if (db.names.back().firs
FYI: Passes "make check-cxxabi" for LLVM in trunk on my machine (x86-64, Ubuntu
16.04) with following standard configuration:
lit.py: /src/try/llvm/projects/libcxx/utils/libcxx/test/config.py:150: note:
Using compiler: /usr/local/bin/clang++
lit.py: /src/try/llvm/projects/libcxx/utils/libcxx/tes
marcel created this revision.
Check whether the string (db.names.back().first) is longer than 7 characters
before inserting another string at index 8.
https://reviews.llvm.org/D33393
Files:
CREDITS.TXT
src/cxa_demangle.cpp
test/test_demangle.pass.cpp
Index: test/test_demangle.pass.cpp
11 matches
Mail list logo
