yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL305805.
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
ruiu added inline comments.
Comment at: clang/include/clang/Driver/Options.td:496
def cl_std_EQ : Joined<["-"], "cl-std=">, Group,
Flags<[CC1Option]>,
- HelpText<"OpenCL language standard to compile for.">;
+ HelpText<"OpenCL language standard to compile for.">,
Values<"cl,C
ruiu accepted this revision.
ruiu added a comment.
LGTM
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor accepted this revision.
teemperor added a comment.
LGTM.
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM. My comments can be addressed in a separate patch.
Comment at: clang/include/clang/Driver/Options.td:496
def cl_std_EQ : Joined<["-"], "cl-std=">, Group,
F
yamaguchi updated this revision to Diff 102982.
yamaguchi added a comment.
Add support and test for
-cl-std=,-fno-sanitize-coverage=,-ffp-contract=,-flto=,-fveclib=,-fshow-overloads=,-fvisibility=,-mfloat-abi=,-mthread-model.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/
yamaguchi updated this revision to Diff 102981.
yamaguchi marked 6 inline comments as done.
yamaguchi added a comment.
Update code comment according to Rui's comment.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/li
ruiu added a comment.
Yuka,
This is beautiful. Overall looking pretty good. Some minor stylistic comments.
Comment at: clang/include/clang/Driver/Options.h:43
+#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM,
\
+ HELPTEXT, METAVAR,
yamaguchi updated this revision to Diff 102964.
yamaguchi added a comment.
Made a trivial change in optionMatches.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions
yamaguchi updated this revision to Diff 102961.
yamaguchi added a comment.
Made trivial change.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions.cpp
clang/test/D
yamaguchi updated this revision to Diff 102960.
yamaguchi added a comment.
Made trivial bug fix.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions.cpp
clang/test/
yamaguchi updated this revision to Diff 102959.
yamaguchi marked an inline comment as done.
yamaguchi added a comment.
Made trivial change.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang
yamaguchi updated this revision to Diff 102958.
yamaguchi marked 10 inline comments as done.
yamaguchi added a comment.
Cleaned suggestValueCompletions and bash-autocomplete.sh, and added tests.
We have passed flags and values from bash to clang like `clang
--autocomplete=l,=,-stdlib`, but I've
yamaguchi updated this revision to Diff 102946.
yamaguchi marked 5 inline comments as done.
yamaguchi added a comment.
Update patch. Rui's comment about the bash part is very reasonable.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/O
ruiu added inline comments.
Comment at: clang/utils/bash-autocomplete.sh:10
+ do
+arg="$arg""${COMP_WORDS[$i]},"
+ done
ruiu wrote:
> nit: you don't need double double-quotes. Instead, `"$arg${COMP_WORDS[$i]},"
> should just work.
On second thought, I thin
ruiu added a comment.
As to the order of Command variable contents, I think I'm not convinced. You
can access the last element as `Command[Command.size() - 1]` (or maybe
`Command.back()`), no? It is slightly awkward than `Command[0]`, but that's not
horribly hard to handle, and passing argument
yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.
Comment at: llvm/lib/Option/OptTable.cpp:198
+ continue;
+std::string S = "-" + std::string(In.Name);
+std::string C = (Command[1] == "=") ?
yamaguchi wrote:
> teemperor wr
yamaguchi added inline comments.
Comment at: clang/test/Driver/autocomplete.c:7
// NONE: foo
+// RUN: %clang --autocomplete=l,=,-stdlib | FileCheck %s -check-prefix=STDLIB
+// STDLIB: libc++ libstdc++
ruiu wrote:
> Why do you want to pass the arguments in the re
yamaguchi updated this revision to Diff 102944.
yamaguchi marked 3 inline comments as done.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update patch and add support for `clang -stdlib=[tab]` case.
In this case we expect to see all possible values.
(Eg. `libc++ libstdc++ platfo
v.g.vassilev added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2198
def stdlib_EQ : Joined<["-", "--"], "stdlib=">, Flags<[CC1Option]>,
- HelpText<"C++ standard library to use">;
+ HelpText<"C++ standard library to use">, Values<"libc++,libstdc++,platfor
ruiu added a comment.
Overall looking good. Good work! A few minor comments.
Comment at: clang/include/clang/Driver/Options.td:2198
def stdlib_EQ : Joined<["-", "--"], "stdlib=">, Flags<[CC1Option]>,
- HelpText<"C++ standard library to use">;
+ HelpText<"C++ standard library
21 matches
Mail list logo
