[PATCH] D33304: [clang-tidy] Add a new module Android and three new checks.

2017-05-31 Thread Yan Wang via Phabricator via cfe-commits
yawanng updated this revision to Diff 100928. yawanng added a comment. Split the commit to three ones that each of them contains one. This is the first part. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMake

[PATCH] D33304: [clang-tidy] Add a new module Android and three new checks.

2017-05-31 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D33304#768961, @yawanng wrote: > In https://reviews.llvm.org/D33304#768731, @alexfh wrote: > > > It's awesome to see another two checks, and it seems to justify adding a > > separate module, but I'd prefer the other two checks to be sent for re

[PATCH] D33304: [clang-tidy] Add a new module Android and three new checks.

2017-05-31 Thread Yan Wang via Phabricator via cfe-commits
yawanng added a comment. In https://reviews.llvm.org/D33304#768731, @alexfh wrote: > It's awesome to see another two checks, and it seems to justify adding a > separate module, but I'd prefer the other two checks to be sent for review as > separate patches to make the review easier and faster.

[PATCH] D33304: [clang-tidy] Add a new module Android and three new checks.

2017-05-31 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. It's awesome to see another two checks, and it seems to justify adding a separate module, but I'd prefer the other two checks to be sent for review as separate patches to make the review easier and faster. https://reviews.llvm.org/D33304 _