And this:
echristo@athyra ~/s/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M include/llvm/MC/MCParser/MCAsmParser.h
M lib/Target/X86/AsmParser/X86AsmParser.cpp
Committed r309005
On Tue, Jul 25, 2017 at 12:18 PM Eric Christopher
wrote:
> I've reverted th
I've reverted this and Nemanja's attempt at fixing in:
echristo@athyra ~/s/l/t/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
D test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
M lib/Sema/SemaStmtAsm.cpp
M test/CodeGen/ms-inline-asm.c
M test/CodeGenCXX/ms-inlin
The test also fails on many other bots on http://lab.llvm.org:8011/console
, a short excerpt:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/9702/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ax86-ms-inline-asm-enum_feature.cpp
http://lab.llvm.org:8011/builders/clang-cmake-aarch64
kcc added a comment.
Hi.
This patch causes the msan bots to complain. Please fix or revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6702/steps/check-clang%20msan/logs/stdio
Testing: 0 .. 10..
FAIL: Clang :: CodeGen/ms_this.cpp (2142 of 11057)
- TEST 'Clang :: C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308965: This patch enables the usage of constant Enum
identifiers within Microsoft… (authored by mharoush).
Changed prior to commit:
https://reviews.llvm.org/D33277?vs=104390&id=108044#toc
Repository:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D33277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush updated this revision to Diff 104390.
mharoush added a comment.
Updated inline asm tests to look for decimal immediate value instead of looking
for the original string e.g. 10 vs 0xA and other variations.
Also updated the test cases to use check-same etc.
Repository:
rL LLVM
https:/
rnk added inline comments.
Comment at: test/CodeGen/x86-ms-inline-asm-enum_feature.cpp:12
+ const int a = 0;
+ // CHECK-NOT: mov eax, [$$0]
+ __asm mov eax, [a]
rnk wrote:
> mharoush wrote:
> > rnk wrote:
> > > Use CHECK-LABEL, CHECK, and CHECK-SAME the way th
mharoush updated this revision to Diff 102172.
mharoush marked 6 inline comments as done.
mharoush added a comment.
Restored old test case for constant int folding and added check-label
directives for each tester function.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sem
mharoush updated this revision to Diff 101693.
mharoush added a comment.
added struct case to the test
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
mharoush updated this revision to Diff 101689.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm.cpp
===
--- lib/Se
rnk added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:674
+ Expr::EvalResult EvlResult;
+ // Try to evaluate the identifier as enum constant
+ if (isa(Res->getType()) && Res->EvaluateAsRValue(EvlResult,
Please add a comment explaining that non-enum
mharoush marked an inline comment as done.
mharoush added inline comments.
Comment at: lib/Parse/ParseStmtAsm.cpp:100
+ // result of a call to LookupInlineAsmIdentifier.
+ bool EvaluateLookupAsEnum(void *LookupResult, int64_t &Result) {
+if (!LookupResult) return false;
---
mharoush updated this revision to Diff 99780.
mharoush added a comment.
removed functions and dropped an irrelevant test case.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
lib/Sema/SemaStmtAsm.cpp
test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Index: lib/Sema/SemaStmtAsm
rnk added inline comments.
Comment at: lib/Parse/ParseStmtAsm.cpp:100
+ // result of a call to LookupInlineAsmIdentifier.
+ bool EvaluateLookupAsEnum(void *LookupResult, int64_t &Result) {
+if (!LookupResult) return false;
Please format this, clang-format w
mharoush created this revision.
mharoush added a project: clang-c.
Herald added a subscriber: eraman.
This patch enables the usage of constant Enum identifiers within Microsoft
style inline assembly statements.
part 1 out of 2.
Repository:
rL LLVM
https://reviews.llvm.org/D33277
Files:
l
17 matches
Mail list logo
