This revision was automatically updated to reflect the committed changes.
Closed by commit rL307723: Enhance synchscope representation (clang) (authored
by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D33109?vs=105499&id=106106#toc
Repository:
rL LLVM
https://reviews.llvm.or
kzhuravl added a comment.
In https://reviews.llvm.org/D33109#73, @mehdi_amini wrote:
> Make sure your commit message correctly reference the LLVM change.
Will do, thanks.
https://reviews.llvm.org/D33109
___
cfe-commits mailing list
cfe-commit
kzhuravl updated this revision to Diff 105499.
kzhuravl marked an inline comment as done.
kzhuravl added a comment.
Address review feedback.
https://reviews.llvm.org/D33109
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-barriers-intrinsics.c
Index: test/CodeGen/ms-barriers-intrinsics.c
=
mehdi_amini accepted this revision.
mehdi_amini added a comment.
Make sure your commit message correctly reference the LLVM change.
Comment at: test/CodeGen/ms-barriers-intrinsics.c:39
#endif
-
Don't remove: file should end with a new line I believe.
https:/
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D33109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
kzhuravl created this revision.
Herald added a subscriber: wdng.
https://reviews.llvm.org/D33109
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-barriers-intrinsics.c
Index: test/CodeGen/ms-barriers-intrinsics.c
===
--- test/Co
