[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-15 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I believe this is good enough now. https://reviews.llvm.org/D33047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; klimek wrote: > ilya-biryukov wrote: > > klimek wrote: > > > I'd have expected something that's called LSP server to work on t

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 98745. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Addressed new comments https://reviews.llvm.org/D33047 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp cl

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-12 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; ilya-biryukov wrote: > klimek wrote: > > I'd have expected something that's called LSP server to work on the LSP > > protocol level

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdMain.cpp:41 // dispatching. - DocumentStore Store; - ASTManager AST(Out, Store, RunSynchronously); - Store.addListener(&AST); + ClangdLSPServer AST(Out, RunSynchronously); JSONRPCDispatcher Dispatcher(llvm::m

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 98634. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed style comments. Moved ClangdScheduler to be the last field of the ClangdServer, so that it's constructed last and destructed first. https://reviews.llvm.org

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clangd/CMakeLists.txt:12 ProtocolHandlers.cpp ) nit: we might want to keep these sorted Comment at: clangd/ClangdMain.cpp:41 // dispatching. - DocumentStore Store; - ASTManager AST(Out, S

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; klimek wrote: > I'd have expected something that's called LSP server to work on the LSP > protocol level (that is, have a ser

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 98606. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed review comments https://reviews.llvm.org/D33047 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D33047: [ClangD] Refactor clangd into separate components

2017-05-11 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; I'd have expected something that's called LSP server to work on the LSP protocol level (that is, have a server(iostream) equivalent