erikjv closed this revision.
erikjv added a comment.
Committed as r304212.
https://reviews.llvm.org/D33042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
I'm new to this review tool. I've addressed the comments and rebased. Does this
needs a re-review? Note that this is my first change and I probably do not have
any permissions to submit this change.
https://reviews.llvm.org/D33042
___
nik updated this revision to Diff 99718.
nik edited the summary of this revision.
https://reviews.llvm.org/D33042
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/libclan
nik marked an inline comment as done.
nik added a comment.
Adapted to the changes that happened in the meanwhile (CINDEX_VERSION_MINOR
increased, CleanTemporaryFiles got removed).
https://reviews.llvm.org/D33042
___
cfe-commits mailing list
cfe-com
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This makes sense to me.
Comment at: lib/Frontend/ASTUnit.cpp:2089
+void ASTUnit::ResetForParse()
+{
+ SavedMainFileBuffer.reset();
Put the `{` on the same
nik added a comment.
Ping :)
https://reviews.llvm.org/D33042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik updated this revision to Diff 98461.
https://reviews.llvm.org/D33042
Files:
include/clang-c/Index.h
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CIndex.cpp
tools/libclang/libclang.exports
Index: tools/libclang/libclang
nik created this revision.
Herald added a subscriber: klimek.
A suspended translation unit uses significantly less memory but on the other
side does not support any other calls than clang_reparseTranslationUnit to
resume it or clang_disposeTranslationUnit to dispose it completely.
This helps IDEs
