This revision was automatically updated to reflect the committed changes.
Closed by commit rL302547: [mips] Impose a threshold for coercion of aggregates
(authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D32900?vs=98269&id=98304#toc
Repository:
rL LLVM
https://reviews.
smaksimovic updated this revision to Diff 98269.
smaksimovic added a comment.
Herald added a subscriber: krytarowski.
Thanks, fixed.
https://reviews.llvm.org/D32900
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/mips-aggregate-arg.c
Index: test/CodeGen/mips-aggregate-arg.c
===
sdardis added a comment.
Spotted a minor nit.
Comment at: test/CodeGen/mips-aggregate-arg.c:36
+ f2(g2);
+ f3(g3);
+}
Nit: spurious whitespace here.
https://reviews.llvm.org/D32900
___
cfe-commits mailing lis
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CodeGen/mips-aggregate-arg.c:3
+// RUN: %clang_cc1 -triple mips64el-unknown-linux-gnu -S -emit-llvm -o - %s
-target-abi n32 | FileCheck -check-pref
smaksimovic created this revision.
Herald added a subscriber: arichardson.
Modified MipsABIInfo::classifyArgumentType so that it now coerces aggregate
structures
only if the size of said aggregate is less than 16/64 bytes, depending on the
ABI.
https://reviews.llvm.org/D32900
Files:
lib/Cod
