eugenis closed this revision.
eugenis added a comment.
r302591, thanks for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D32886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
eugenis added a comment.
I'll fix the other unnecessary MakeArgString calls in a separate commit
Repository:
rL LLVM
https://reviews.llvm.org/D32886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
eugenis updated this revision to Diff 98354.
eugenis marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
pcc accepted this revision.
pcc added a comment.
LGTM
Unfortunate, but I guess this is in the same category as things like
`-fsized-deallocation`.
Comment at: lib/Driver/SanitizerArgs.cpp:573
+
+// This is a workaround for a bug in gold and enabled by default for
non-ELF
eugenis updated this revision to Diff 98200.
Herald added a subscriber: krytarowski.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
l
eugenis added inline comments.
Comment at: include/clang/Driver/Options.td:830
HelpText<"Disable use-after-scope
detection in AddressSanitizer">;
+def fsanitize_address_globals_live_support : Flag<["-"],
"fsanitize-address-globals-liv
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Generally makes sense. A question about the name. Feel free to land with a name
that you and other sanitizer folks are happy with.
Comment at: include/clang/Driver/Opt
eugenis updated this revision to Diff 97901.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/SanitizerArgs.cpp
lib/Fronte
eugenis created this revision.
This feature is subtly broken when the linker is gold 2.26 or
earlier. See the following bug for details:
https://sourceware.org/bugzilla/show_bug.cgi?id=19002
Since the decision needs to be made at compilation time, we can not
test the linker version. The flag i
