[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

2017-05-03 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Thanks for being flexible; committed in r302095. Maybe longer term we could add a CMake configuration for whether to include the tests, but naming it might be hard ;). https://reviews.llvm.org/D32836 ___ cfe-commits ma

[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

2017-05-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm OK with this patch because it's minimally invasive. However it seems strange to support arbitrary configurations that delete random parts of the source tree. https://reviews.llvm.org/D32

[PATCH] D32836: CMake: Only add test/ subdirectory when it exists

2017-05-03 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. Herald added a subscriber: mgorny. CMake: Only add test/ subdirectory when it exists r296685 started adding the test/ subdirectory even when LIBCXX_INCLUDE_TESTS=OFF. This is great for testing libcxx standalone, but it also breaks the build when the test/ subdir