This revision was automatically updated to reflect the committed changes.
Closed by commit rL304463: [Modules] Handle sanitizer feature mismatches when
importing modules (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D32724?vs=98371&id=101088#toc
Repository:
rL LLVM
aprantl accepted this revision.
aprantl added a comment.
This is good from my point of view now. You might want to wait for an ok from
@spyffe.
https://reviews.llvm.org/D32724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
vsk added a comment.
Ping.
https://reviews.llvm.org/D32724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk updated this revision to Diff 98371.
vsk marked 2 inline comments as done.
vsk added a comment.
Address comments from Adrian. (I settled on renaming 'getModularSanitizers' to
'getPPTransparentSanitizers'.)
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basi
aprantl added inline comments.
Comment at: include/clang/Basic/Sanitizers.h:64
- /// \brief Disable all sanitizers.
- void clear() { Mask = 0; }
+ /// \brief Disable the sanitizers specified in \p K (by default, disable
+ /// all sanitizers).
Might as well
vsk updated this revision to Diff 98363.
vsk added a comment.
I've uploaded the correct diff this time, sorry for the confusion.
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basic/LangOptions.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Serialization/ASTRea
vsk updated this revision to Diff 98349.
vsk marked 7 inline comments as done.
vsk added a comment.
Add a comment explaining how and why ASTReader checks for sanitizer feature
mismatches.
https://reviews.llvm.org/D32724
Files:
include/clang/Basic/Sanitizers.h
lib/Basic/LangOptions.cpp
li
vsk updated this revision to Diff 98343.
vsk retitled this revision from "[Modules] Include the enabled sanitizers in
the module hash" to "[Modules] Handle sanitizer feature mismatches when
importing modules".
vsk edited the summary of this revision.
vsk added a comment.
If compatible difference
