[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-05-03 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. Ping :) https://reviews.llvm.org/D32670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 97198. dim added a comment. Simplify test case a bit. https://reviews.llvm.org/D32670 Files: include/locale test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minmax_showbase.pass.cpp Index: test/std/input.

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. Note: I copied some of the test case from https://reviews.llvm.org/rL227097, which had a similar case of a too short buffer. https://reviews.llvm.org/D32670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. Herald added a subscriber: emaste. In https://bugs.freebsd.org/207918, Daniel McRobb describes how using std::showbase with ostreams can cause truncation of unsigned long long when output format is octal. In fact, this can even happen with unsigned int and unsigned long