This revision was automatically updated to reflect the committed changes.
Closed by commit rL301597: [Modules] Improve diagnostics for incomplete
umbrella (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D32576?vs=96857&id=97007#toc
Repository:
rL LLVM
https://reviews.
dexonsmith added a comment.
Oh, and it would be nice to split out
`Preprocessor::diagnoseMissingHeaderInUmbrellaDir` in a separate NFC commit
ahead of time.
https://reviews.llvm.org/D32576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM after a couple of changes inline.
Comment at: lib/Lex/PPLexerChange.cpp:290-292
+static void
+collectAllSubModulesWithUmbrellaHeader(Module *Mod,
+
bruno created this revision.
One of the -Wincomplete-umbrella warnings diagnoses when a header is present in
the directory but it's not present in the umbrella header. Currently, this
warning only happens on top level modules; any submodule using an umbrella
header does not get this warning. Fi
