This revision was automatically updated to reflect the committed changes.
Closed by commit rL303353: [clang-format] Fix MatchingOpeningBlockLineIndex
computation (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D32524?vs=99136&id=99442#toc
Repository:
rL LLVM
https:
krasimir added a comment.
It should be enough for commit access. Mention your patches while requesting
commit access. I'll submit this in the meantime.
https://reviews.llvm.org/D32524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Typz added a comment.
Indeed, I don't have commit access. But I was wondering if I should not get it,
to simplify landing the patches after review.
I read http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access about
this, but I am still wondering what is considered a "track record of
krasimir added a comment.
Do you need me to commit this?
https://reviews.llvm.org/D32524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
I don't have commit access, can someone please commit this patch?
https://reviews.llvm.org/D32524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
I can't think of a test case either. Thanks!
https://reviews.llvm.org/D32524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Typz updated this revision to Diff 99136.
Typz added a comment.
Reformat and remove unneeded comment
https://reviews.llvm.org/D32524
Files:
lib/Format/UnwrappedLineParser.cpp
Index: lib/Format/UnwrappedLineParser.cpp
===
--- li
Typz added a comment.
I tried to add some test, but could not find a simple way: I could not find any
'parser' tests from which to start, and I don't see with current master how
this can be an issue (though it becomes an issue with some of other patches).
Any hint how to implement some test?
h
krasimir added a comment.
Thank you! A test would be nice.
Comment at: lib/Format/UnwrappedLineParser.cpp:432
size_t OpeningLineIndex =
- Lines.empty() ? (UnwrappedLine::kInvalidIndex) : (Lines.size() - 1);
+ CurrentLines->empty() ? (UnwrappedLine::kInvalidIndex) :
