[PATCH] D32514: [asan] Unconditionally enable GC of globals on COFF

2017-04-25 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis added a comment. r301374 Repository: rL LLVM https://reviews.llvm.org/D32514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D32514: [asan] Unconditionally enable GC of globals on COFF

2017-04-25 Thread Nico Weber via cfe-commits
See https://bugs.chromium.org/p/chromium/issues/detail?id=715315 Looks good, please land to get the tree back green while we investigate. On Apr 25, 2017 8:51 PM, "Evgeniy Stepanov via Phabricator via cfe-commits" wrote: > eugenis added a comment. > > Apparently the ODR detector in Asan on Wind

[PATCH] D32514: [asan] Unconditionally enable GC of globals on COFF

2017-04-25 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis added a comment. Apparently the ODR detector in Asan on Windows has issues with full data-sections. This way we can have limited GC for user globals. Repository: rL LLVM https://reviews.llvm.org/D32514 ___ cfe-commits mailing list cfe-co

[PATCH] D32514: [asan] Unconditionally enable GC of globals on COFF

2017-04-25 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Why? Repository: rL LLVM https://reviews.llvm.org/D32514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32514: [asan] Unconditionally enable GC of globals on COFF

2017-04-25 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis created this revision. This change restores pre-r301225 behavior, where linker GC compatible global instrumentation was used on COFF targets disregarding -f(no-)data-sections and/or /Gw flags. Repository: rL LLVM https://reviews.llvm.org/D32514 Files: lib/CodeGen/BackendUtil.cpp