v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r301563.
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
OK
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
Yaron, I can take care of this. Thanks for asking. Raphael and I are working
together.
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
yaron.keren added a comment.
Raphael , do you have commit access? should I commit this?
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
teemperor updated this revision to Diff 96561.
teemperor added a comment.
- Now using unique_ptr instead of raw pointers.
https://reviews.llvm.org/D32486
Files:
lib/Frontend/PrintPreprocessedOutput.cpp
Index: lib/Frontend/PrintPreprocessedOutput.cpp
=
yaron.keren added a comment.
Please move the =new out of the PP.AddPragmaHandler calls.
While at it, this code still (as the original) leaks the PragmaHandlers. These
should be deleted after RemovePragmaHandler or instead, simply use
std::unique_ptr.
https://reviews.llvm.org/D32486
teemperor created this revision.
The UnknownPragmaHandlers added by t`DoPrintPreprocessedInput` conflict with
the real PragmaHandlers from clang::Parser because they try to handle the same
`#pragma` directives. This makes it impossible to use a Preprocessor (that was
previously passed to DoPrin
