[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-24 Thread Francois Ferrand via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL303739: clang-format: Introduce BreakConstructorInitializers option (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D32479?vs=99887&id=100068#toc Repository: rL LLVM https://re

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-24 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->Tot

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->TotalLength - Previous.TotalLength > + getColumnLimit(State) || djasper wrote:

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 99887. Typz added a comment. Cleanup according to review comment https://reviews.llvm.org/D32479 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->TotalLength - Previous.TotalLength > + getColumnLimit(State) || Typz wrote:

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 99886. Typz marked 3 inline comments as done. Typz added a comment. Refactor to avoid duplicating code, and fix typo in test. https://reviews.llvm.org/D32479 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz marked 6 inline comments as done. Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->TotalLength - Previous.TotalLength > + getColumnLimit(Sta

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->TotalLength - Previous.TotalLength > + getColumnLimit(State) || Typz wrote:

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 99856. Typz added a comment. Add missing doc for BreakConstructorInitializers https://reviews.llvm.org/D32479 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp unittests/Forma

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->TotalLength - Previous.TotalLength > + getColumnLimit(State) || djasper wrote:

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-23 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 99854. Typz marked 5 inline comments as done. Typz added a comment. respond to review comments https://reviews.llvm.org/D32479 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

2017-05-22 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: include/clang/Format/Format.h:699 + /// This option is **deprecated* and is retained for backwards compatibility. bool BreakConstructorInitializersBeforeComma; I don't think you need to keep this around. The YAML p