[PATCH] D32435: clang-cl: Add support for /permissive-

2019-09-20 Thread Trass3r via Phabricator via cfe-commits
Trass3r added a comment. Has this ever gotten anywhere? I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32435/new/ https://reviews.llvm.o

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread Nico Weber via cfe-commits
On Tue, Apr 25, 2017 at 5:28 PM, David Majnemer wrote: > > > On Tue, Apr 25, 2017 at 2:12 PM, Nico Weber wrote: > >> On Tue, Apr 25, 2017 at 4:14 PM, David Majnemer > > wrote: >> >>> >>> >>> On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber >>> wrote: >>> On Tue, Apr 25, 2017 at 2:06 PM, David

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread David Majnemer via cfe-commits
On Tue, Apr 25, 2017 at 2:12 PM, Nico Weber wrote: > On Tue, Apr 25, 2017 at 4:14 PM, David Majnemer > wrote: > >> >> >> On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber wrote: >> >>> On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer < >>> david.majne...@gmail.com> wrote: >>> On Tue, A

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread Nico Weber via cfe-commits
On Tue, Apr 25, 2017 at 4:14 PM, David Majnemer wrote: > > > On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber wrote: > >> On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer > > wrote: >> >>> >>> >>> On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote: >>> On Mon, Apr 24, 2017 at 10:00 PM, David Maj

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread David Majnemer via cfe-commits
On Tue, Apr 25, 2017 at 11:42 AM, Nico Weber wrote: > On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer > wrote: > >> >> >> On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote: >> >>> On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer < >>> david.majne...@gmail.com> wrote: >>> On Mon,

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread Nico Weber via cfe-commits
On Tue, Apr 25, 2017 at 2:06 PM, David Majnemer wrote: > > > On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote: > >> On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer < >> david.majne...@gmail.com> wrote: >> >>> >>> >>> On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber >>> wrote: >>> "Opting int

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread David Majnemer via cfe-commits
On Tue, Apr 25, 2017 at 8:46 AM, Nico Weber wrote: > On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer > wrote: > >> >> >> On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber wrote: >> >>> "Opting into the conforming mode, /permissive-, during the series of VS >>> 2017 update is a commitment to keeping

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-25 Thread Nico Weber via cfe-commits
On Mon, Apr 24, 2017 at 10:00 PM, David Majnemer wrote: > > > On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber wrote: > >> "Opting into the conforming mode, /permissive-, during the series of VS >> 2017 update is a commitment to keeping your code base clean and to fixing >> non-conforming constructs

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread David Majnemer via cfe-commits
On Mon, Apr 24, 2017 at 11:56 AM, Nico Weber wrote: > "Opting into the conforming mode, /permissive-, during the series of VS > 2017 update is a commitment to keeping your code base clean and to fixing > non-conforming constructs we fix conformance issues in Visual C++." [...] > "By contrast /per

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread Nico Weber via cfe-commits
majnemer: opinion on the above? On Apr 24, 2017 2:56 PM, "Nico Weber" wrote: > "Opting into the conforming mode, /permissive-, during the series of VS > 2017 update is a commitment to keeping your code base clean and to fixing > non-conforming constructs we fix conformance issues in Visual C++."

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread Nico Weber via cfe-commits
"Opting into the conforming mode, /permissive-, during the series of VS 2017 update is a commitment to keeping your code base clean and to fixing non-conforming constructs we fix conformance issues in Visual C++." [...] "By contrast /permissive- offers a useful conformance mode where input C++ code

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread David Majnemer via cfe-commits
-pedantic means "Issue all the warnings demanded by strict ISO C and ISO C++; reject all programs that use forbidden extensions, and some other programs that do not follow ISO C and ISO C++." I believe it is more akin to -fno-ms-compatibility as it disables compatibility hacks. On Mon, Apr 24, 201

Re: [PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread Nico Weber via cfe-commits
It does sound pretty similar to me from the blog post. I think this is a decent place to start from. On Apr 24, 2017 11:55 AM, "David Majnemer via Phabricator via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > majnemer requested changes to this revision. > majnemer added a comment. > This re

[PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread David Majnemer via Phabricator via cfe-commits
majnemer requested changes to this revision. majnemer added a comment. This revision now requires changes to proceed. I don't think this is correct. GDR (of Microsoft) says the behavior is different: https://www.reddit.com/r/cpp/comments/5dh7j5/visual_c_introduces_permissive_for_conformance/da5f

[PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D32435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D32435: clang-cl: Add support for /permissive-

2017-04-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/ makes it sound like this is similar to -pedantic, which we currently don't expose from clang-cl. So map it to that for now and see how that feels in practice. Looks like cl.exe only has a flag fo