[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-25 Thread İsmail Dönmez via Phabricator via cfe-commits
ismail abandoned this revision. ismail added a comment. compnerd has a better fix. https://reviews.llvm.org/D32427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I think that you should mutate the environment in the canonicalisation phase of the triple. That will allow you to use `armv7-suse-linux-gnueabi` and `armv7-suse-linux-gnueabihf` in the frontend, but have the backend always get `armv7-suse-linux-gnueabihf`. https://

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread İsmail Dönmez via Phabricator via cfe-commits
ismail added a comment. I am open to suggestions on how to do this correctly. The problem as stated is all SUSE ARM triples end with -gnueabi but they are all hard-float. Environment handling in LLVM seems to only check for the last part of the triple and not the whole string. https://reviews

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. I'm not sure the results will really work that well either. https://reviews.llvm.org/D32427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread Renato Golin via Phabricator via cfe-commits
rengolin added reviewers: compnerd, rovka, joerg. rengolin added a comment. I'm not sure this will work at all. Not because it doesn't make sense (it does), but because of several bugs in the soft vs. hard float implementation in the Triple related classes all the way to the back-end. I'm addin

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread İsmail Dönmez via Phabricator via cfe-commits
ismail updated this revision to Diff 96382. ismail added a comment. Fix typo https://reviews.llvm.org/D32427 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/linux-as.c Index: test/Driver/linux-as.c === --- test/Driver/l

[PATCH] D32427: Fix float abi for SUSE ARM triples

2017-04-24 Thread İsmail Dönmez via Phabricator via cfe-commits
ismail created this revision. Herald added a subscriber: aemerson. SUSE's ARM triples always ends with -gnueabi but all the targets are hard-float https://reviews.llvm.org/D32427 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/linux-as.c Index: test/Driver/linux-as.c ===