This revision was automatically updated to reflect the committed changes.
Closed by commit rL301648: [libclang] Expose some target information via the C
API. (authored by emilio).
Changed prior to commit:
https://reviews.llvm.org/D32389?vs=96834&id=97109#toc
Repository:
rL LLVM
https://revi
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D32389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
emilio updated this revision to Diff 96834.
emilio added a comment.
Updated per review comments, thanks :)
Repository:
rL LLVM
https://reviews.llvm.org/D32389
Files:
clang/include/clang-c/Index.h
clang/test/Index/target-info.c
clang/tools/c-index-test/c-index-test.c
clang/tools/libcl
arphaman added a comment.
It looks good, I have a couple of comments:
Comment at: clang/include/clang-c/Index.h:1573
+CINDEX_LINKAGE void
+clang_TargetInfo_dispose(CXTargetInfo info);
+
Please capitalize `Info` here and in the other parameter lists.
=
emilio updated this revision to Diff 96652.
emilio added a comment.
Updated per comments, I used `clang_TargetInfo_dispose` following recent APIs
instead of `clang_disposeTargetInfo`, let me know if I should change that.
Also, didn't add a new header for `CXTargetInfo`, since it's rather small,
emilio added a comment.
Sounds good to me, will do :)
Repository:
rL LLVM
https://reviews.llvm.org/D32389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Maybe it would be better to introduce a `CXTargetInfo` type, and change the API
to be:
clang_getTranslationUnitTargetInfo
clang_TargetInfo_getTriple
clang_TargetInfo_getPointerWidth
?
This way the `TargetInfo` functions will be cleanly separated, so we can extend
emilio added a comment.
I'd appreciate if anyone could point me to an appropriate reviewer for this.
Thanks in advance! :)
Repository:
rL LLVM
https://reviews.llvm.org/D32389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
emilio created this revision.
emilio added a project: clang-c.
This allows users to query the target triple and target pointer width, which
would make me able to fix https://github.com/servo/rust-bindgen/issues/593 and
other related bugs in an elegant way (without having to manually parse the
targ
