yamaguchi closed this revision.
yamaguchi added a comment.
Landed in r305561.
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, good job! (Sorry for the delay, I think I got interrupted here by the
GSoC start...)
https://reviews.llvm.org/D32341
___
cfe-commits
yamaguchi added a comment.
@teemperor ping..?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
@teemperor, is this ok with you?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi updated this revision to Diff 97019.
yamaguchi added a comment.
Add testcase
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
===
--- test/D
yamaguchi updated this revision to Diff 97013.
yamaguchi added a comment.
show warnings with -M and -MD
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
=
v.g.vassilev added a comment.
I think you will see the issue if you add a negative test case, too. I.e. as
Raphael said in `-MD` and `-MMD` mode we should be able to see warnings.
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-com
yamaguchi added a comment.
Do you think it is not a good idea to change condition if -MD or -MMD exists?
for example,
if ( !A->getOption().matches(options::OPT_MD) &&
!A->getOption().matches(options::OPT_MQ)) CmdArgs.push_back("-w");
https://reviews.llvm.org/D32341
__
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
This also disables warnings for `-MD` and `-MMD` which shouldn't happen as
we're actually compiling code here and are probably compiling a project. E.g.
for people that use thi
yamaguchi updated this revision to Diff 96283.
yamaguchi added a comment.
Fixed typo.
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
===
--- test/Dr
v.g.vassilev added a comment.
LGTM modulo the comments.
Comment at: test/Driver/m_and_mm.c:7
+// RUN: not grep "warning" %t
+#warning "This warning shouldn't shop up with -M and -MM"
Typo.
https://reviews.llvm.org/D32341
___
yamaguchi updated this revision to Diff 96273.
yamaguchi added a comment.
Add testcase.
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
===
--- test/
v.g.vassilev added a comment.
Could you add a test case?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi created this revision.
This is a patch for bug [1]
Warnings should not be emitted with -M and -MM flags, because this mode is only
used for generate MakeFiles.
[1]:
https://bugs.llvm.org/show_bug.cgi?id=6817
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
14 matches
Mail list logo
