dexonsmith closed this revision.
dexonsmith added a comment.
Fixed in r301592.
https://reviews.llvm.org/D32263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith added a comment.
s/Eli/Eric/
https://reviews.llvm.org/D32263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith updated this revision to Diff 96201.
dexonsmith added a comment.
Thanks for the review, Eli.
I've changed `IsModule` to be a required `bool*` parameter. Setting the
default to `nullptr` looked confusing at call sites.
https://reviews.llvm.org/D32263
Files:
clang/include/clang/Le
eric_niebler added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:401
+ }
+
/// \brief Look up a subframework for the specified \#include file.
Why not just add a `, bool *IsMapped = nullptr` parameter to the existing
`LookupFile`?
htt
dexonsmith created this revision.
If a file search involves a header map, suppress
-Wnonportable-include-path. It's firing lots of false positives for
framework authors internally, and it's not trivial to fix.
Consider a framework called "Foo" with a main (installed) framework header
"Foo/Foo.h"
