[PATCH] D31765: Skip Unicode character expansion in assembly files

This revision was automatically updated to reflect the committed changes. Closed by commit rL299754: Skip Unicode character expansion in assembly files (authored by sanwou01). Changed prior to commit: https://reviews.llvm.org/D31765?vs=94501&id=94505#toc Repository: rL LLVM https://reviews.

[PATCH] D31765: Skip Unicode character expansion in assembly files

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D31765: Skip Unicode character expansion in assembly files

salari01 updated this revision to Diff 94501. salari01 added a comment. Updated test to check preprocessed output instead of the assembled file. Cannot use `-verify` with the driver, but with `-E` and `-o -`, there is no longer a need to have the dummy warning to avoid the FileCheck error. htt

[PATCH] D31765: Skip Unicode character expansion in assembly files

olista01 added a comment. The change itself looks fine, but I have a few comments on the test. Tests of clang shouldn't actually run the assembler, as I think this one will fail if clang is built without the ARM backend. A better way to write the test would be to just run the preprocessor, and

[PATCH] D31765: Skip Unicode character expansion in assembly files

salari01 created this revision. When using the C preprocessor with assembly files, either with a capital `S` file extension, or with `-xassembler-with-cpp`, the Unicode escape sequence `\u` is ignored. The `\u` pattern can be used for expanding a macro argument that starts with `u`. https://r