[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

2017-04-03 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Makes sense to me. Some questions inline, but they may not necessitate changes, so I'm accepting. Comment at: lib/CMakeLists.txt:166 + if (NOT LIBCXX_ENABLE_NEW_DELET

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

2017-04-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 94000. EricWF added a comment. - Remove silly changes to `libc++abi2.exp` https://reviews.llvm.org/D31644 Files: lib/CMakeLists.txt lib/libc++abi-new-delete.exp lib/libc++abi2.exp Index: lib/libc++abi2.exp

[PATCH] D31644: [libcxx] Fix check-cxx-abilist on OS X

2017-04-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. Herald added a subscriber: mgorny. Recent commits broke the check-cxx-abilist by changing the default OS X to use `-rexport_library` instead of `-reexport_symbol_list`. Apparently `-reexport_library` doesn't export the symbols into `libc++.dylib`s symbol table, whe