[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-23 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. Fixed: r303714 = 8832327ab89f3668378d70d1c4e5a218446ce36e https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-23 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. In https://reviews.llvm.org/D31608#762783, @alekseyshl wrote: > Leaks and warnings are reported in coro-await.cpp: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio. > Please fix. Thank you! The fi

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-23 Thread Aleksey Shlyapnikov via Phabricator via cfe-commits
alekseyshl added a comment. Leaks and warnings are reported in coro-await.cpp: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1400/steps/check-clang%20asan/logs/stdio. Please fix. https://reviews.llvm.org/D31608 ___ cfe-

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-22 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov closed this revision. GorNishanov added a comment. r303603 = 12cdab350043e7ff931af5f13d3e3afe85b76628 https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-22 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-20 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. @EricWF: Can you take a quick look? Just a sanity check. The change is rather trivial. https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-15 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. soft ping https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-05-01 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. Weakly (sp) ping https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-04-24 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. Tiny ping https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-04-10 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. Pretty please. Gentle ping. https://reviews.llvm.org/D31608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-04-03 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov updated this revision to Diff 93889. GorNishanov added a comment. Added a CHECK that for a final suspend we correctly set "IsFinalSuspend" argument of @llvm.coro.suspend https://reviews.llvm.org/D31608 Files: lib/CodeGen/CGCoroutine.cpp test/CodeGenCoroutines/coro-await.cpp t

[PATCH] D31608: [coroutines] Add emission of initial and final suspends

2017-04-03 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. https://reviews.llvm.org/D31608 Files: lib/CodeGen/CGCoroutine.cpp test/CodeGenCoroutines/coro-await.cpp test/CodeGenCoroutines/coro-cleanup.cpp Index: test/CodeGenCoroutines/coro-cleanup.cpp ===