v.g.vassilev added a comment.
Landed in r300313.
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi added a comment.
I don't have a commit access. Can you commit?
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM.
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
It seems to me the test have already been simplified enough, so I'm not
quite sure what you are trying to do more than this. Isn't this just ready
to submit?
On Wed, Apr 12, 2017 at 5:46 PM, Yuka Takahashi via Phabricator <
revi...@reviews.llvm.org> wrote:
> yamaguchi updated this revision to Dif
yamaguchi updated this revision to Diff 95064.
yamaguchi added a comment.
I've been trying to minimal the testcase, add comments to describe what it is
testing, and fix styles of the testcase properly.
However, I don't have clear idea what will be the best. I would like to ask for
the advice.
v.g.vassilev added a comment.
ping...
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
@yamaguchi, I'd support Akira's comment. Could you place the minimal test
example in the suggested file?
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ruiu added a comment.
Is this a minimal test case that can produce the issue? It'd be awesome if you
can reduce it.
sema-segvcheck.c is not a good name for this test because that name can be used
for any crash bug. You want to see other files in the same directory to name
your file so that it'
ahatanak added inline comments.
Comment at: clang/test/Sema/sema-segvcheck.c:3
+// RUN: %clang_cc1 -fsyntax-only %s; test $? -eq 1
+
+typedef struct {
You can simplify the test case. Compiling the following code still segfaults:
```
typedef struct {
unsigned l
yamaguchi updated this revision to Diff 94090.
yamaguchi added a comment.
Add relative path to the file.
https://reviews.llvm.org/D31591
Files:
clang/test/Sema/sema-segvcheck.c
lib/Sema/SemaInit.cpp
Index: clang/test/Sema/sema-segvcheck.c
==
yamaguchi updated this revision to Diff 93864.
yamaguchi added a comment.
Made unified diff for the testcase and SemaInit.cpp.
https://reviews.llvm.org/D31591
Files:
SemaInit.cpp
sema-segvcheck.c
Index: sema-segvcheck.c
===
-
yamaguchi updated this revision to Diff 93860.
yamaguchi added a comment.
Moved comment inside if (ExistingInit).
https://reviews.llvm.org/D31591
Files:
SemaInit.cpp
Index: SemaInit.cpp
===
--- SemaInit.cpp
+++ SemaInit.cpp
@@
12 matches
Mail list logo
