[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG27e2ff964fc3: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace… (authored by yaron.keren). H

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren reopened this revision. yaron.keren added a comment. reverted in r300497 Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

This revision was automatically updated to reflect the committed changes. Closed by commit rL300443: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace… (authored by yrnkrn). Changed prior to commit: https://reviews.llvm.org/D31540?vs=94961&id=95425#toc Repository:

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. LGTM! https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren updated this revision to Diff 94961. yaron.keren added a comment. Added attribute test. https://reviews.llvm.org/D31540 Files: tools/clang/include/clang/AST/DeclBase.h tools/clang/lib/AST/Decl.cpp tools/clang/lib/AST/DeclBase.cpp tools/clang/test/SemaTemplate/friend-template

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren added a comment. Thanks, I'll make a test. Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. Could you also add the testcase where the friend declaration has some attributes? Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren created this revision. Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp. Repository: rL LLVM ht