[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

2017-04-18 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 updated this revision to Diff 95548. sanwou01 added a comment. Herald added subscribers: mgorny, klimek. Rebase on top of https://reviews.llvm.org/D31709 and https://reviews.llvm.org/D32159 https://reviews.llvm.org/D31501 Files: include/clang/Basic/Diagnostic.h include/clang/Basic

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

2017-04-03 Thread Oliver Stannard via Phabricator via cfe-commits
olista01 added a comment. That all sounds sensible from an assembler perspective, especially the ability to gradually move diagnostics into categories rather than having one big change that touches every assembler diag. However, I've not done much work in clang, so it would be good to get someo

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

2017-04-03 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 added a comment. Hi Oli, Thanks for taking a look! You're right, -w and -Werror could be implemented by passing them as MCTargetOptions flags. This patch is indeed intended to enable -W options to promote or silence (categories of) warnings. To enable that, the first step is to be abl

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

2017-03-31 Thread Oliver Stannard via Phabricator via cfe-commits
olista01 added a comment. What advantages does this have over the current way of printing diagnostics? If this is just to get -w and -Werror working, would it not be easier to pass those through to the assembler, than to send all diagnostics back through clang? We already have some flags in MCT

[PATCH] D31501: [RFC] Integrate clang -cc1as diagnostics into DiagnosticsEngine

2017-03-30 Thread Sanne Wouda via Phabricator via cfe-commits
sanwou01 created this revision. Herald added a subscriber: aemerson. Add initial support for printing assembly diagnostics using the DiagnosticsEngine infrastructure. Add support for -w (no warnings) and -Werror (warnings are errors) and print a summary with the number of errors and warnings. -fc