This revision was automatically updated to reflect the committed changes.
Closed by commit rL299465: [clang-format] fix crash in
NamespaceEndCommentsFixer (PR32438) (authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D31441?vs=93507&id=94108#toc
Repository:
rL LLVM
https
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Great!
https://reviews.llvm.org/D31441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
mgehre updated this revision to Diff 93507.
mgehre added a comment.
Updated for comments
https://reviews.llvm.org/D31441
Files:
lib/Format/NamespaceEndCommentsFixer.cpp
unittests/Format/NamespaceEndCommentsFixerTest.cpp
Index: unittests/Format/NamespaceEndCommentsFixerTest.cpp
===
krasimir added a comment.
Looks good! I just have two nits.
Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:139
+}
if (NamespaceTok->isNot(tok::kw_namespace))
continue;
I'd instead just add a guard check at old line 136:
```
if (!Namespace
mgehre created this revision.
Herald added a subscriber: klimek.
The new test case was crashing before. Now it passes
as expected.
https://reviews.llvm.org/D31441
Files:
lib/Format/NamespaceEndCommentsFixer.cpp
unittests/Format/NamespaceEndCommentsFixerTest.cpp
Index: unittests/Format/Nam
