faisalv closed this revision.
faisalv added a comment.
Committed as https://reviews.llvm.org/rL303594
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
faisalv marked 2 inline comments as done.
faisalv added a comment.
mark aaron's feedback as done.
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv updated this revision to Diff 99787.
faisalv added a comment.
Incorporated Aaron's feedback - thanks Aaron!
https://reviews.llvm.org/D31414
Files:
include/clang/Basic/TemplateKinds.h
include/clang/Sema/ParsedTemplate.h
lib/Parse/ParseExprCXX.cpp
lib/Parse/ParseTemplate.cpp
Inde
aaron.ballman added inline comments.
Comment at: include/clang/Sema/ParsedTemplate.h:202
+ SmallVectorImpl &CleanupList) {
+ ;
+ TemplateIdAnnotation *TemplateId = new (std::malloc(
Spurious semi colon?
Comment at: include/c
faisalv added a comment.
*ping*
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv updated this revision to Diff 93207.
faisalv added a comment.
Don't forget to destroy the trailing objects.
https://reviews.llvm.org/D31414
Files:
include/clang/Basic/TemplateKinds.h
include/clang/Sema/ParsedTemplate.h
lib/Parse/ParseExprCXX.cpp
lib/Parse/ParseTemplate.cpp
Inde
faisalv created this revision.
faisalv added a project: clang-c.
Refactor TemplateIdAnnotation to use TrailingObjects and add assorted comments.
Repository:
rL LLVM
https://reviews.llvm.org/D31414
Files:
include/clang/Basic/TemplateKinds.h
include/clang/Sema/ParsedTemplate.h
lib/Parse/
