This revision was automatically updated to reflect the committed changes.
Closed by commit rL299421: [clangd] Add code completion support (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31328?vs=92948&id=94026#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3132
stanionascu added inline comments.
Comment at: clangd/Protocol.cpp:613
+ if (CI.kind != CompletionItemKind::Missing)
+Os << R"("kind":)" << static_cast(CI.kind) << R"(",)";
+ if (!CI.detail.empty())
if kind is actually provided there will be a trailing quot
bkramer accepted this revision.
bkramer added a comment.
lg
https://reviews.llvm.org/D31328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Ideas/Observations:
- One thing I has done in my version is to introduce "ASTUnitRunnable", a
lambda function type that has an ASTUnit as parameter and is executed by the
ASTManager. So the ASTManager takes care of locking the AST but the actual code
using t
malaperle-ericsson added inline comments.
Comment at: test/clangd/formatting.test:14
+# CHECK: "codeActionProvider": true,
+# CHECK: "completionProvider": {"resolveProvider": false,
"triggerCharacters": [".",">"]}
# CHECK: }}}
It would be good eventually to
krasimir updated this revision to Diff 92948.
krasimir added a comment.
- Make Items ownership more explicit
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
cla
malaperle-ericsson added a comment.
Urg, I was working on this too :) I'll compare implementations and provide
comments if I find anything good to suggest.
https://reviews.llvm.org/D31328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
krasimir updated this revision to Diff 92940.
krasimir marked 7 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
c
krasimir updated this revision to Diff 92939.
krasimir added a comment.
- Add '.' and '>' as completion trigger characters
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHand
bkramer added inline comments.
Comment at: clangd/ASTManager.cpp:264
+assert(CCS->getTypedText());
+Item.label = llvm::yaml::escape(CCS->getTypedText());
+if (CCS->getBriefComment())
CompletionItem::unparse should do the escaping. It's wei
krasimir updated this revision to Diff 92931.
krasimir added a comment.
- Clean-up leftovers
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHand
krasimir created this revision.
Adds code completion support to clangd.
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHandlers.h
test/clangd/
12 matches
Mail list logo
