[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh added a comment. Committed as r308726. Thank you for the contribution! One note for the future: the patch doesn't contain repository-based paths, so I had to apply it manually. There's a good documentation at http://llvm.org/docs/Phabricator.html, which you could follow to create the p

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL308726: [clang-tidy] Add option to export fixes to run-clang-tidy.py (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D31326?vs=107633&id=107650#toc Repository: rL LLVM https:

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst added a comment. Many thanks! https://reviews.llvm.org/D31326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. I'll commit the patch for you https://reviews.llvm.org/D31326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 107633. mfherbst added a comment. Remove compatiblity with clang-tidy < 4.0.0 https://reviews.llvm.org/D31326 Files: run-clang-tidy.py Index: run-clang-tidy.py === --- run-clang-tidy.py +++

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/tool/run-clang-tidy.py:96-98 + # Clang-tidy < 4.0.0 uses "Replacements" as a key to the list + # of replacements. Clang-tidy >= 4.0.0 u

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 107254. mfherbst added a comment. Adapt patch to the changes since the initial submission. Most notably the introduction of clang-tidy-4.0 changed the format in which clang-tidy dumps the required changes. This needs to be taken into account when merging t

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh added a comment. In https://reviews.llvm.org/D31326#803535, @mfherbst wrote: > I do not have commit rights to the svn if that's what you're asking, but I > could send the patch to llvm-commits if that makes it easier for you. No need to send the patch to the list separately, Phabricator

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst added a comment. I do not have commit rights to the svn if that's what you're asking, but I could send the patch to llvm-commits if that makes it easier for you. https://reviews.llvm.org/D31326 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 105835. mfherbst added a comment. Correct the nits suggested by alexfh https://reviews.llvm.org/D31326 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py ===

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Just noticed another couple of nits, otherwise looks good. Thanks! Do you need me to commit the patch for you? Comment at: clang-tidy/tool/run-clang-tidy.py:158 +

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst added inline comments. Comment at: run-clang-tidy.py:93 +def merge_replacement_files(tmpdir, fixfile): + """Merge all replacement files in a directory into a single fixfile""" + # MainSourceFile: The key is required by the definition inside alexfh wrot

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 105818. mfherbst added a comment. Correct nits and typos. https://reviews.llvm.org/D31326 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-ti

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few more nits. Comment at: run-clang-tidy.py:93 +def merge_replacement_files(tmpdir, fixfile): + """Merge all replacement files in a directory into a single fixf

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst added inline comments. Comment at: run-clang-tidy.py:105 + elif merged['MainSourceFile'] != content['MainSourceFile']: +# The values given for MainSourceFile are inconsistent. +# Just empty MainSourceFile blank: alexfh wrote: > This

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 105592. mfherbst added a comment. Herald added a subscriber: JDevlieghere. - Adapted patch to changes suggested by alexfh - Added comment why setting MainSourceFile to an empty string if fixes are exported https://reviews.llvm.org/D31326 Files: run-clan

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: run-clang-tidy.py:49 +import yaml +import glob Please sort the imports Comment at: run-clang-tidy.py:99 +

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

mfherbst updated this revision to Diff 92986. mfherbst added a comment. Fixed typos (MainFile => MainSourceFile) https://reviews.llvm.org/D31326 Files: run-clang-tidy.py Index: run-clang-tidy.py === --- run-clang-tidy.py +++ ru