[PATCH] D31276: Add #pragma clang fast_math

2017-03-28 Thread Adam Nemet via Phabricator via cfe-commits
anemet updated this revision to Diff 93325. anemet retitled this revision from "Add #pragma clang fp" to "Add #pragma clang fast_math". anemet edited the summary of this revision. anemet added a comment. Rename pragma from #pragma clang fast_math contract_fast(on/off) -> #pragma clang fp contrac

[PATCH] D31276: Add #pragma clang fast_math

2017-03-25 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. In https://reviews.llvm.org/D31276#710608, @hfinkel wrote: > In https://reviews.llvm.org/D31276#709111, @anemet wrote: > > > In https://reviews.llvm.org/D31276#708992, @hfinkel wrote: > > > > > High-level comment ;) > > > > > > #pragma clang fast_math contract_fast(on) >

[PATCH] D31276: Add #pragma clang fast_math

2017-03-25 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D31276#709111, @anemet wrote: > In https://reviews.llvm.org/D31276#708992, @hfinkel wrote: > > > High-level comment ;) > > > > #pragma clang fast_math contract_fast(on) > > > > > > This seems a bit unfortunate because 'fast' appears twice?

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. In https://reviews.llvm.org/D31276#708999, @hfinkel wrote: > They're definitely on my list. I might not get to them until the weekend or > next week, however. Thank you. The schedule is getting tight but that should still work ;). Actually most of the individual patch

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. In https://reviews.llvm.org/D31276#708992, @hfinkel wrote: > High-level comment ;) > > #pragma clang fast_math contract_fast(on) > > > This seems a bit unfortunate because 'fast' appears twice? How are we > planning on naming the other fast-math flags? Maybe we shoul

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D31276#708993, @anemet wrote: > In https://reviews.llvm.org/D31276#708976, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D31276#708968, @anemet wrote: > > > > > Thanks very much, Aaron! It would be great if you could also look at the

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. In https://reviews.llvm.org/D31276#708976, @aaron.ballman wrote: > In https://reviews.llvm.org/D31276#708968, @anemet wrote: > > > Thanks very much, Aaron! It would be great if you could also look at the > > three patches that add support for the generation of the new FM

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. High-level comment ;) #pragma clang fast_math contract_fast(on) This seems a bit unfortunate because 'fast' appears twice? How are we planning on naming the other fast-math flags? Maybe we should just name it: #pragma clang math constract_fast(on) or #pragma cl

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D31276#708968, @anemet wrote: > Thanks very much, Aaron! It would be great if you could also look at the > three patches that add support for the generation of the new FMF 'contract' > for -ffp-contract=fast. I've added them in the de

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet added a comment. Thanks very much, Aaron! It would be great if you could also look at the three patches that add support for the generation of the new FMF 'contract' for -ffp-contract=fast. I've added them in the dependencies of this revision. (https://reviews.llvm.org/D31168 is not r

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D31276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet added inline comments. Comment at: docs/LanguageExtensions.rst:2321 +specified for a section of the source code. This pragma can only appear at +file scope or at the start of a compound statement. When using within a +compound statement, the pragma is active within the s

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Adam Nemet via Phabricator via cfe-commits
anemet updated this revision to Diff 92825. anemet marked 4 inline comments as done. anemet added a comment. Address Aaron's comments. Also add a code example to the documentation. https://reviews.llvm.org/D31276 Files: docs/LanguageExtensions.rst include/clang/Basic/DiagnosticParseKinds.t

[PATCH] D31276: Add #pragma clang fast_math

2017-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:2319 + +The ``#pragma clang fast_math`` allows floating-point fast-math options to be +specified for a section of the source code. This pragma can only appear at Missing "pragma" in fro

[PATCH] D31276: Add #pragma clang fast_math

2017-03-22 Thread Adam Nemet via Phabricator via cfe-commits
anemet created this revision. This adds the new pragma and the first variant, contract_fast. The pragma has the same block scope rules as STDC FP_CONTRACT, i.e. it can be placed at the beginning of a compound statement or at file scope. Similarly to STDC FP_CONTRACT there is no need to use attri