mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 298573
https://reviews.llvm.org/D31234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Although it would be useful to test that `hash>` and
`hash>` do not have noexcept call operators.
Alternatively should we make `hash` conditionally noexcept for `variant` and
`optional`
mclow.lists updated this revision to Diff 92645.
mclow.lists added a comment.
Add missing include to the `thread::id` test and mark `unique_ptr`s hash as not
noexcept.
https://reviews.llvm.org/D31234
Files:
include/memory
include/optional
include/thread
include/variant
test/std/conta
mclow.lists created this revision.
Mark most of the hash functions provided by libc++ as noexcept; the exceptions
being `optional` and `variant`.
Tests to ensure this.
There's still some investigation to be done on `unique_ptr` and fancy pointer
support, but that can come later.
https://revie
