[PATCH] D31179: Objective-C categories should support attributes

2018-08-01 Thread Dmitry Lobanov via Phabricator via cfe-commits
lolgear added a comment. Herald added subscribers: llvm-commits, dexonsmith. Well, deprecated category only shows "Implementing deprecated category" message. However, I would like to tell users that all methods of this category are deprecated. For that I need to add deprecated attribute for each

[PATCH] D31179: Objective-C categories should support attributes

2017-03-23 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL298589: Support attributes for Objective-C categories (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31179?vs=92454&id=92782#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D31179: Objective-C categories should support attributes

2017-03-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: test/SemaObjC/attr-deprecated.m:124-128 +@interface A(Blah) // no warning +- (A*)getA; @end +@implementation A(Blah) // no warning aaron.ballman wrote: > I would have assumed the use in the `@implementation` would ha

[PATCH] D31179: Objective-C categories should support attributes

2017-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/SemaObjC/attr-deprecated.m:124-128 +@interface A(Blah) // no warning +- (A*)getA; @end +@implementation A(Blah) // no warning I would have assumed the use in the `@implementation` would have been enough to

[PATCH] D31179: Objective-C categories should support attributes

2017-03-21 Thread Nathan Hawes via Phabricator via cfe-commits
nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Thanks for this – looks good to me! Repository: rL LLVM https://reviews.llvm.org/D31179 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D31179: Objective-C categories should support attributes

2017-03-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Sorry about an empty body, I had a keyboard malfunction. I have updated the patch now. Repository: rL LLVM https://reviews.llvm.org/D31179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg