This revision was automatically updated to reflect the committed changes.
Closed by commit rL299435: Fix exception address alignment test for EHABI
(authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D31178?vs=94074&id=94075#toc
Repository:
rL LLVM
https://reviews.llvm.or
rmaprath updated this revision to Diff 94074.
rmaprath added a comment.
Herald added a subscriber: mgorny.
Addressed review comments from @EricWF .
https://reviews.llvm.org/D31178
Files:
CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.site.cfg.in
test/test_exception_address_alignm
EricWF added a comment.
For the most part this LGTM other than the nits mentioned.
Comment at: test/libcxxabi/test/config.py:34
+'libunwind_src',
+os.path.join(self.libcxxabi_src_root, '/../libunwind/src'))
I think the correct default
rengolin added a comment.
This looks like a simple oversight from my perspective, so looks good.
But I'll let the others have a look at it, as I'm not overly familiar with
libcxxabi.
cheers,
--renato
https://reviews.llvm.org/D31178
___
cfe-commit
rmaprath updated this revision to Diff 92450.
rmaprath added a comment.
Fixed a few paths.
https://reviews.llvm.org/D31178
Files:
test/libcxxabi/test/config.py
test/lit.site.cfg.in
test/test_exception_address_alignment.pass.cpp
Index: test/test_exception_address_alignment.pass.cpp
=
rmaprath created this revision.
Herald added a subscriber: aemerson.
This test was failing on our downstream (bare-metal) runs and only now I got
around to investigate it.
The problem is, this test assumes the Itanium ABI, whereas EHABI requires the
exception address to be 8-byte aligned.
I wa
