This revision was automatically updated to reflect the committed changes.
Closed by commit rL299419: [clang-rename] Support renaming qualified symbol
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D31176?vs=93474&id=94021#toc
Repository:
rL LLVM
https://reviews.llvm
hokein updated this revision to Diff 93474.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix a few nits.
https://reviews.llvm.org/D31176
Files:
clang-rename/CMakeLists.txt
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
clan
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few nits.
Comment at: clang-rename/RenamingAction.cpp:104
+ USRList[I], NewNames[I], Context.getTranslationUnitDecl());
+ for (const auto AtomicChange
hokein updated this revision to Diff 93469.
hokein marked an inline comment as done.
hokein added a comment.
update comments.
https://reviews.llvm.org/D31176
Files:
clang-rename/CMakeLists.txt
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
cla
hokein added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:359
+
+ // Returns a list of using declarations which are needed to update.
+ const std::vector &getUsingDecls() const {
ioeric wrote:
> hokein wrote:
> > ioeric wrote:
> > > I think these
hokein updated this revision to Diff 93468.
hokein marked 2 inline comments as done.
hokein added a comment.
Use AtomicChange.
https://reviews.llvm.org/D31176
Files:
clang-rename/CMakeLists.txt
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
cl
ioeric added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:195
+// Find all locations identified by the given USRs. Traverse the AST and find
+// every AST node whose USR is in the given USRs' set.
+class RenameLocFinder
hokein wrote:
> ioeric wrote:
hokein added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:195
+// Find all locations identified by the given USRs. Traverse the AST and find
+// every AST node whose USR is in the given USRs' set.
+class RenameLocFinder
ioeric wrote:
> I think this
hokein updated this revision to Diff 92954.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments and polish tests.
https://reviews.llvm.org/D31176
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
clang-rename/USRFin
ioeric added inline comments.
Comment at: clang-rename/USRFinder.cpp:200
+ // Also find all USRs of nested declarations.
+ NestedNameSpecifierLocFinder Finder(const_cast(Context));
ioeric wrote:
> It is unclear to me what `nested declarations` are.
But what i
hokein added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:157
+clang::NestedNameSpecifierLoc nested_name_specifier =
+TL.castAs().getQualifierLoc();
+if (nested_name_specifier.getNestedNameSpecifier())
ioeric wrote:
> Is this cast al
hokein updated this revision to Diff 92636.
hokein marked 14 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D31176
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
clang-rename/USRFindingA
ioeric added a comment.
I think this is a great start!
First round with some nits.
Comment at: clang-rename/RenamingAction.cpp:87
+class QualifiedRenamingASTConsumer : public ASTConsumer {
+public:
Comments.
Comment at: clang-rename/Renam
13 matches
Mail list logo
