[PATCH] D31162: IRGen: Do not set dllexport on declarations.

2017-03-20 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL298330: IRGen: Do not set dllexport on declarations. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D31162?vs=92412&id=92416#toc Repository: rL LLVM https://reviews.llvm.org/D3

[PATCH] D31162: IRGen: Do not set dllexport on declarations.

2017-03-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Lgtm https://reviews.llvm.org/D31162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31162: IRGen: Do not set dllexport on declarations.

2017-03-20 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. Setting dllexport on a declaration has no effect, as we do not emit export directives for declarations. Part of the fix for PR32334. https://reviews.llvm.org/D31162 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenCXX/dllexport.cpp Index: clang/test