aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r298229. If we want to reword the hicpp-no-assembler diagnostic, we
can do so in a follow-up patch.
https://reviews.llvm.org/D31128
___
cfe-commits mailing list
cfe-commit
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
jbcoe wrote:
> aaron.ballman wrote:
> > jbcoe wrote:
> > > Should this message use text tak
JonasToth accepted this revision.
JonasToth added a comment.
thank you very much for dealing with this issue :)
I will update the aliases. But maybe later this week since i have an exam. :)
https://reviews.llvm.org/D31128
___
cfe-commits mailing lis
jbcoe accepted this revision.
jbcoe added a comment.
This revision is now accepted and ready to land.
LGTM.
Great work on getting this module approved by PRQA Aaron.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in saf
aaron.ballman added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
jbcoe wrote:
> Should this message use text taken directly from the HICPP rules?
The wordin
jbcoe added inline comments.
Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+
+ diag(ASMLocation, "do not use inline assembler in safety-critical code");
+}
Should this message use text taken directly from the HICPP rules?
https://reviews.llvm.org/D31128
aaron.ballman created this revision.
Herald added a subscriber: mgorny.
This module is intended to comply with the High-Integrity C++ coding standard
by PRQA, so we should be explicit about that in the name of the module and the
checks. This patch looks larger than it really is. It:
- Renames t
