This revision was automatically updated to reflect the committed changes.
Closed by commit rL299229: [mips][msa] Range adjustment for ldi_b builtin
function operand (authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D31082?vs=92439&id=93669#toc
Repository:
rL LLVM
https
smaksimovic updated this revision to Diff 92439.
smaksimovic added a comment.
Added a new test to test/CodeGen/builtins-mips-msa.c, covering the new extended
range for ldi.b.
https://reviews.llvm.org/D31082
Files:
lib/Sema/SemaChecking.cpp
test/CodeGen/builtins-mips-msa-error.c
test/Code
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
Can you add a test to test/CodeGen/builtins-mips-msa.c covering the new
extended range for ldi.b ?
LGTM.
https://reviews.llvm.org/D31082
___
smaksimovic created this revision.
Reasoning behind this change was allowing the function to accept all values
from range [-128, 255] since all of them can be encoded in an 8bit wide value.
This differs from the prior state where only range [-128, 127] was accepted,
where values were assumed to
