[PATCH] D30845: Fix array sizes where address space is not yet known

2017-03-21 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kzhuravl marked an inline comment as done. Closed by commit rL298420: Fix array sizes where address space is not yet known (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D30845?vs=91404&id=92523

[PATCH] D30845: Fix array sizes where address space is not yet known

2017-03-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Comment at: lib/AST/ASTContext.cpp:2696 + ArySize = ArySize.zextOrTrunc( + Target->getPreferredPointerWidth(getTargetAddressSpace(EltTy))); Can we j

[PATCH] D30845: Fix array sizes where address space is not yet known

2017-03-10 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl added a comment. I am not sure if this is the right way to fix it. https://reviews.llvm.org/D30845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30845: Fix array sizes where address space is not yet known

2017-03-10 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl created this revision. Herald added a subscriber: wdng. For variables in generic address spaces, for example: unsigned char V[6442450944]; ... the address space is not yet known when we get into *getConstantArrayType*, it is 0. AMDGCN target's address space 0 has 32 bits pointers,