JDevlieghere abandoned this revision.
JDevlieghere added a comment.
In https://reviews.llvm.org/D30792#697802, @mehdi_amini wrote:
> Off topic, but since this is a rev lock change with LLVM, you can to all of
> in a single revision with:
> http://llvm.org/docs/GettingStarted.html#for-developers
mehdi_amini added a comment.
Off topic, but since this is a rev lock change with LLVM, you can to all of in
a single revision with:
http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo
Repository:
rL LLVM
https://reviews.llvm.org/D30792
JDevlieghere updated this revision to Diff 91292.
JDevlieghere added a comment.
- Pass StringSet by const ref.
Repository:
rL LLVM
https://reviews.llvm.org/D30792
Files:
include/clang/CodeGen/CodeGenAction.h
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CodeGenAction.cpp
lib/Fr
JDevlieghere updated this revision to Diff 91282.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
- Reformat
- Call helper rather than initializing the pass
Repository:
rL LLVM
https://reviews.llvm.org/D30792
Files:
include/clang/CodeGen/CodeGenAction.h
inclu
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM with the format fix I pointed out.
Comment at: lib/CodeGen/CodeGenAction.cpp:186
+} else {
+ Err = Linker::linkModules(*getModule(), std::move(LM.
tejohnson added a comment.
Great, thanks. One question below and a format nit.
Comment at: lib/CodeGen/CodeGenAction.cpp:177
+if (LM.Internalize) {
+ Err = Linker::linkModules(
+ *getModule(), std::move(LM.Module), LM.LinkFlags,
Need
