[PATCH] D30765: Reexport operator new / delete from libc++abi

2017-03-29 Thread Mehdi AMINI via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299054: Reexport operator new / delete from libc++abi (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D30765?vs=91091&id=93445#toc Repository: rL LLVM https://reviews.ll

[PATCH] D30765: Reexport operator new / delete from libc++abi

2017-03-22 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. We'll hear soon enough if this starts causing problems. https://reviews.llvm.org/D30765 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D30765: Reexport operator new / delete from libc++abi

2017-03-08 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Note: this is already shipping like this for ~2 years in our OSes. https://reviews.llvm.org/D30765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30765: Reexport operator new / delete from libc++abi

2017-03-08 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini created this revision. Both libc++ and libc++abi export a weak definition of operator new/delete. On Darwin, this can often cause dirty __DATA in the shared cache when having to switch from one to the other. Instead, libc++ should reexport libc++abi's implementation of these symbols.