This revision was automatically updated to reflect the committed changes.
Closed by commit rL297371: [include-fixer] Remove line number from Symbol
identity (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D30685?vs=90990&id=91149#toc
Repository:
rL LLVM
https://re
bkramer accepted this revision.
bkramer added a comment.
lg
https://reviews.llvm.org/D30685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM once Ben has no other comments. Be careful before submitting it (this
patch also changes the interface).
https://reviews.llvm.org/D30685
__
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D30685#695284, @hokein wrote:
> > We may want to track individual occurrences (line number, full type info)
> > and aggregate this during mapreduce, but that's not done here.
>
> Seems reasonable.
sammccall updated this revision to Diff 90990.
sammccall added a comment.
Address review comments. Uncovered two bugs:
- accidentally casting through bool: EXPECT_EQ(1, hasSymbol) was a lie
- we were double counting uses of typedefs where the underlying type was built
in, because qualType(hasDec
hokein added a comment.
> We may want to track individual occurrences (line number, full type info)
> and aggregate this during mapreduce, but that's not done here.
Seems reasonable. So we will introduce a new structure to track these
occurrences? Or reuse the `SymbolInfo::Signals`?
sammccall created this revision.
Remove line number from Symbol identity.
For our purposes (include-fixer and clangd autocomplete), function overloads
within the same header should mostly be treated as a single combined symbol.
We may want to track individual occurrences (line number, full type
